Skip to content

Add Windows Certificate Store Integration Tile #20337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2025
Merged

Conversation

mrafi97
Copy link
Contributor

@mrafi97 mrafi97 commented May 20, 2025

What does this PR do?

Adds the integration tile for the Windows Certificate Store core check: DataDog/datadog-agent#36658

Motivation

https://datadoghq.atlassian.net/browse/WINA-1446

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mrafi97 mrafi97 force-pushed the mrafi/windows_cert_store branch from 2ec7853 to 0b1d0ab Compare May 20, 2025 14:55
@maycmlee
Copy link
Contributor

Created DOCS-10967 for review.

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review from a docs team editor label May 20, 2025
@maycmlee maycmlee removed their assignment May 21, 2025
Copy link
Contributor

@shanelhuang shanelhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small wording suggestions

Co-authored-by: Shanel Huang <[email protected]>
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback, including a few typos, but otherwise looks good.

Co-authored-by: Rosa Trieu <[email protected]>
@mrafi97 mrafi97 requested a review from rtrieu May 29, 2025 18:48
@mrafi97 mrafi97 added this pull request to the merge queue May 30, 2025
Merged via the queue into master with commit 1c92482 May 30, 2025
47 of 48 checks passed
@mrafi97 mrafi97 deleted the mrafi/windows_cert_store branch May 30, 2025 20:20
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* adding Windows Certificate Store check

* Update README.md

* updating manifest, dashboard, and changelog

* fixing monitor and manifest

* Update windows_certificate_expiration.json

* Updating README

Co-authored-by: Shanel Huang <[email protected]>

* updating dashboard with new logo

* Update README

Co-authored-by: Rosa Trieu <[email protected]>

---------

Co-authored-by: Shanel Huang <[email protected]>
Co-authored-by: Rosa Trieu <[email protected]> 1c92482
github-actions bot pushed a commit to vinodkumar-sacumen/integrations-core that referenced this pull request Jun 1, 2025
* adding Windows Certificate Store check

* Update README.md

* updating manifest, dashboard, and changelog

* fixing monitor and manifest

* Update windows_certificate_expiration.json

* Updating README

Co-authored-by: Shanel Huang <[email protected]>

* updating dashboard with new logo

* Update README

Co-authored-by: Rosa Trieu <[email protected]>

---------

Co-authored-by: Shanel Huang <[email protected]>
Co-authored-by: Rosa Trieu <[email protected]> 1c92482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants